Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/add Dialog stories #3751

Merged
merged 11 commits into from
Oct 10, 2023
Merged

Docs/add Dialog stories #3751

merged 11 commits into from
Oct 10, 2023

Conversation

green6erry
Copy link
Contributor

Parent issue: https://github.com/github/primer/issues/1488

Add storybook stories for Dialog

Checklist

  • Ensure your chosen component has a component directory in the src directory
  • Ensure the component has a root story file in the component directory
  • Ensure that the root story file exports a Default story
  • (Optional) Create a Playground story
  • Move all other stories for the component into a .features.stories.tsx file
  • Opt the component into storybook tests
  • (Optional) Create visual regression tests for the component

@green6erry green6erry requested review from a team and joshblack September 18, 2023 21:03
@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ad7d21e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.7 KB (+0.01% 🔺)
dist/browser.umd.js 105.27 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-3751 September 18, 2023 21:09 Inactive
@green6erry green6erry temporarily deployed to github-pages September 18, 2023 21:10 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3751 September 18, 2023 21:10 Inactive
langermank
langermank approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to address the lint errors before merging :)

@joshblack joshblack removed their request for review September 25, 2023 20:04
@green6erry green6erry temporarily deployed to github-pages October 10, 2023 14:11 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3751 October 10, 2023 14:11 Inactive
@green6erry green6erry temporarily deployed to github-pages October 10, 2023 14:18 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3751 October 10, 2023 14:18 Inactive
@green6erry green6erry added the skip changeset This change does not need a changelog label Oct 10, 2023
@green6erry green6erry temporarily deployed to github-pages October 10, 2023 15:33 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3751 October 10, 2023 15:33 Inactive
@green6erry green6erry temporarily deployed to github-pages October 10, 2023 15:41 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3751 October 10, 2023 15:41 Inactive
@green6erry green6erry changed the title Docs/add dialog stories Docs/add Dialog stories Oct 10, 2023
@green6erry green6erry self-assigned this Oct 10, 2023
@green6erry green6erry added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 115e09c Oct 10, 2023
31 checks passed
@green6erry green6erry deleted the docs/add-Dialog-stories branch October 10, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees

@green6erry green6erry

Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@green6erry @langermank